Update deps, swap tiny-glob for fast-glob #963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwpow
commented
Oct 30, 2022
| @@ -114,11 +116,11 @@ async function generateSchema(pathToSpec) { | |||
|
|
|||
| // output | |||
| if (output === OUTPUT_FILE) { | |||
| let outputFilePath = path.resolve(process.cwd(), flags.output); // note: may be directory | |||
There was a problem hiding this comment.
Overdue cleanup: URL() is a vastly-preferred way to work with the filesystem in Node, because it’s not only faster, but it also works in both Windows and *nix systems without any fuss. And no more awkward path.join() or conditional path.sep logic; simply use forward slashes and It Just Works™
path.resolve() is a bit of a convoluted mess under-the-hood. It’s great when it works, but it’s a headache when it doesn’t.
drwpow
commented
Oct 30, 2022
| @@ -4,14 +4,15 @@ | |||
| "declaration": true, | |||
| "esModuleInterop": true, | |||
| "forceConsistentCasingInFileNames": true, | |||
| "lib": ["ES2018"], | |||
There was a problem hiding this comment.
Another overdue cleanup: most modern versions of Node don’t need legacy codegen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updates deps, swaps tiny-glob for fast-glob (former hasn’t been updated in quite some time).
mainis failing CI; will fix in a following PR.How to Review
See comments
Checklist
examples/directory updated (if applicable)