Skip to content

fix: export enum of operation paths #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2022

Conversation

duncanbeevers
Copy link
Contributor

@duncanbeevers duncanbeevers commented May 10, 2022

Closes #911

🗣 Discussion

Pretty straight-forward. I was just about to use this functionality myself when I encountered the unreachable enum.

The enum was being generated, but simply wasn't exported.
This PR adds the export, and updates the associated spec output.

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #912 (8b79503) into main (c0eef5f) will not change coverage.
The diff coverage is n/a.

❗ Current head 8b79503 differs from pull request most recent head cd8a827. Consider uploading reports for the commit cd8a827 to get more accurate results

@@            Coverage Diff            @@
##              main      #912   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48f2b93...cd8a827. Read the comment docs.

@duncanbeevers duncanbeevers force-pushed the fix/export-paths-enum branch from 8b79503 to cd8a827 Compare May 22, 2022 03:04
Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix! Thank you 🙏

@drwpow drwpow merged commit 08d42a6 into openapi-ts:main May 24, 2022
@duncanbeevers duncanbeevers deleted the fix/export-paths-enum branch May 24, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ApiPaths enum does not exported by default
2 participants