Fix serialize object #910
Merged
Fix serialize object #910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Last one! Once this one is rebased off |
duncanbeevers
force-pushed
the
fix-serialize-object
branch
from
44169b2 to
426cb09
Compare
|
@drwpow Rebased on |
drwpow
reviewed
Jun 1, 2022
| @@ -639,7 +639,7 @@ export interface definitions { | |||
| sso_url?: string; | |||
| /** @enum {string} */ | |||
| version?: "v1"; | |||
| /** @default [object Object] */ | |||
drwpow
reviewed
Jun 1, 2022
| @@ -49,7 +49,8 @@ export function prepareComment(v: CommentObject): string | void { | |||
| if (v[field] === "" && !allowEmptyString) { | |||
| continue; | |||
| } | |||
| commentsArray.push(`@${field} ${v[field]} `); | |||
| const serialized = typeof v[field] === "object" ? JSON.stringify(v[field], null, 2) : v[field]; | |||
drwpow
approved these changes
Jun 1, 2022
|
Will ship all these in a release later today. Thanks for your patience, and thanks so much for all these awesome improvements 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complex
defaultandexamplevalues were serialized in comments at[Object object].This PR attempts to recognize these values, and to serialize them in a more-useful way.
This PR depends on both #909 and #906