Supports minItems / maxItems

[kgtkr]

fix #871

[changeset-bot]

⚠️ No Changeset found

Latest commit: b7a41fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[drwpow]

Awesome tests!

[drwpow]

This is great, thank you!

[codecov]

Codecov Report

Merging #872 (1009944) into main (c0eef5f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #872   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb5e199...1009944. Read the comment docs.

[drwpow]

I’m in favor of merging this, but on second thought, I’d like to see the following added:

• There’s no documentation in the README, nor the --help flag on how to use this new feature. How would a user use this? When would they want to use this?
• There are no tests in the CLI to test if this flag is working (there are good TypeScript tests, but we’re not checking the --support-array-length flag is passed correctly)

Could you address both of the following?

[kgtkr]

Thanks. I added a test.
The difference between with and without the option is, for example, test/v3/expected/github.support-array-length.ts:16633.

[drwpow]

@all-contributors please add @kgtkr for code, docs

[allcontributors]

@drwpow

I've put up a pull request to add @kgtkr! 🎉