Create interfaces for additionalProperties objects #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enmand
force-pushed
the
dan/improvements/swagger-additionalProperties
branch
2 times, most recently
from
fb6a7e8 to
f6d84ac
Compare
davidharrigan
approved these changes
Feb 22, 2019
enmand
force-pushed
the
dan/improvements/swagger-additionalProperties
branch
from
f6d84ac to
47af2da
Compare
drwpow
reviewed
Feb 22, 2019
| @@ -181,7 +198,7 @@ function parse(spec: Swagger2, namespace: string) { | |||
|
|
|||
| output.push('}'); // Close namespace | |||
|
|
|||
| return prettier.format(output.join('\n'), { parser: 'typescript' }); | |||
| return prettier.format(output.join('\n'), { parser: 'typescript', singleQuote: true }); | |||
There was a problem hiding this comment.
Just a note: I personally like singleQuote, but since we’re open-sourcing it I didn’t know the best thing to decide on. Maybe we could add options one day to allow customization of this, but this is fine for now (we can always change it if someone asks!)
|
@enmand are you able to add a test to |
drwpow
reviewed
Feb 22, 2019
|
|
||
| expect(swaggerToTS(swagger)).toBe(ts); | ||
| }); | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds supports for object definitions with
additionalProperties: boolean | Swagger2Definition