Infer Return Type for select from useInfiniteQuery
#2169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for openapi-ts pending review.Visit the deploys page to approve it
|
🦋 Changeset detectedLatest commit: 3c70089 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
awmichel
force-pushed
the
infer-select-return-from-infinite-query
branch
from
78225d2 to
cab51d4
Compare
drwpow
approved these changes
May 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updates the types for
useInfiniteQueryto infer the return type from theselectoption, if provided. Adds onto #2105 with recent addition of #2117.Also adds the docs for
useInfiniteQueryto the navigation in the docs site, it wasn't being linked to, and adds a note about customizing the query param name for pagination.How to Review
See previous PR for the type inference in #2105 and additional test added to the
useInfiniteQuerysuite to check the return type is correctly inferred and functionally sound from useInfiniteQuery.Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)