Update bug/feature templates #2041
Conversation
|
size-limit report 📦
|
| @@ -0,0 +1,42 @@ | |||
| --- | |||
| name: "Bug report: swr-openapi" | |||
There was a problem hiding this comment.
@htunnicliff Any changes/unique questions you’d like to ask for swr-openapi? (Ditto for feature requests)?
| @@ -0,0 +1,30 @@ | |||
| --- | |||
| name: "Feature request: openapi-react-query" | |||
There was a problem hiding this comment.
@kerwanp Any unique descriptions / questions you’d like to add for openapi-react-query? (Same for feature request)?
| about: For the openapi-fetch library | ||
| title: "" | ||
| labels: openapi-fetch, bug | ||
| assignees: "" |
There was a problem hiding this comment.
I originally started to see if we could auto-assign to a specific team, but I think we need a custom action to do a round-robin assignment that I’ll add in a followup (assigning to the entire team means we all get notified, and I wanted to find a solution where we don’t all get notified for everything).
But in me examining the templates, I realized these were a little stale and could use some updating.
There was a problem hiding this comment.
I think this is a nice modernization. I've left some comments (some of them apply to all templates, I just left them once).
RE the "code of conduct" checkbox. Do you feel there is a lot of value in having explicit acknowledgment of the code of conduct? (it's not like adhering to it is optional either way, but enforcement might be helped by an explicit ack).
| - type: input | ||
| attributes: | ||
| label: OS + version | ||
| placeholder: macOS 15.1.1 | ||
| validations: | ||
| required: true |
There was a problem hiding this comment.
Do we see OS specific issues a lot? (then a gain, it's little to ask, so maybe better to ask right away).
There was a problem hiding this comment.
Especially with openapi-typescript, quite a lot! It’s also why we have Windows tests. Anything that talks to the filesystem, really, it’s important to know what OS they’re on. Put another way, it’s basically a “are you using Windows” question.
There was a problem hiding this comment.
Anything that talks to the filesystem, really, it’s important to know what OS they’re on.
Ah, yes, good point!
| options: | ||
| - label: I agree to follow this project's [Code of Conduct](https://github.com/openapi-ts/openapi-typescript/blob/main/CODE_OF_CONDUCT.md) | ||
| required: true | ||
| - label: My OpenAPI schema is valid and passes the [Redocly validator](https://redocly.com/docs/cli/commands/lint/) (`npx @redocly/cli@latest lint`) |
Deploying openapi-ts with
|
| Latest commit: |
1aa7215
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3d45b89b.openapi-ts.pages.dev |
| Branch Preview URL: | https://update-templates.openapi-ts.pages.dev |
Changes
Updates our bug/feature issue templates to use the new form format with validations! Also adds templates for openapi-react-query and swr-openapi
How to Review
Checklist
N/A