Skip to content

Add an option to export the namespace #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 17, 2019
Merged

Conversation

tpdewolf
Copy link
Contributor

I'm autogenerating types on build and had to add the export keyword every time. I thought it would be nice to add it as an option. I even would suggest to enable it by default but I didnt want to change the current default behaviour

@codecov-io
Copy link

codecov-io commented Apr 11, 2019

Codecov Report

Merging #11 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   94.36%   94.52%   +0.15%     
==========================================
  Files           2        2              
  Lines          71       73       +2     
  Branches       17       19       +2     
==========================================
+ Hits           67       69       +2     
  Misses          4        4
Impacted Files Coverage Δ
src/swagger-2.ts 94.11% <100%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 596d90b...d68cb66. Read the comment docs.

@drwpow
Copy link
Contributor

drwpow commented Apr 11, 2019

Nice! I really like this.

I’d like to add a test for this option. I’m happy to merge this and add it, or you can take a crack at adding a test if you’d prefer. Which would you like?

@drwpow
Copy link
Contributor

drwpow commented Apr 17, 2019

@tpdewolf I’m going to merge this, and add a test as a followup. I’ll release a new version to npm this week. Thanks again!

@drwpow drwpow merged commit 11a1d3a into openapi-ts:master Apr 17, 2019
@drwpow
Copy link
Contributor

drwpow commented Apr 19, 2019

Thanks for your patience. v1.1.3 is now on npm with your export option. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants