Skip to content

feat: add with required utility to enforce properties of allOf #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 23, 2023

Conversation

Swiftwork
Copy link
Contributor

Changes

Resolves #657

How to Review

Resolves the issue described in #657 and updates the unit tests. Should be a fairly safe change as it is just additive to the current code generation without breaking changes. This solution will only work for OpenAPI 3.1 as described by the comment here #657 (comment)

Checklist

  • Unit tests updated
  • README updated
  • examples/ directory updated (if applicable)

Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. There may be some cases where we might need a little more code generation than this, but I think this is an improvement. We can come back to those cases as they become clearer.

@drwpow drwpow merged commit 6fa6bea into openapi-ts:main Feb 23, 2023
@drwpow
Copy link
Contributor

drwpow commented Feb 23, 2023

@all-contributors please add @Swiftwork for code, bug, test

@allcontributors
Copy link
Contributor

@drwpow

I've put up a pull request to add @Swiftwork! 🎉

@Swiftwork Swiftwork deleted the pr/all-of-required branch February 23, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Advanced required enforcement for allOf + required case
2 participants