Support fully-qualified refs as discriminator mapping values #1017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgrimm
changed the title
|
@all-contributors please add @sgrimm for code, bug, test |
|
I've put up a pull request to add @sgrimm! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1016
How to Review
I took my best guess at what the test for this should look like based on the existing test suite. The new test does demonstrate the bug (fails in the same way as my real-world case, passes with the code change). But it feels a bit brittle to me, in that it's hardwiring a bunch of context and the source of the original bug was a mismatch between what was really in that context and what the code expected to be there.
Happy to revise this if you think the test isn't adequate.
Checklist
examples/directory updated (if applicable)