-
-
Notifications
You must be signed in to change notification settings - Fork 230
Feat: Schema datatypes validation by pydantic
#478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Schema datatypes validation by pydantic
#478
Conversation
Codecov Report
@@ Coverage Diff @@
## main #478 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 47 48 +1
Lines 1588 1596 +8
=========================================
+ Hits 1588 1596 +8
Continue to review full report at Codecov.
|
Returned tests for bad |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great change, definitely improves the clarity of what's expected. Just would like to still point at 3.0.3 spec since we don't support 3.1.0 yet.
A little suggestion for type checking in the
Schema
: Looks like it is a task forpydantic
in input. This is more obvious and allows to reduce test cases.