Skip to content

Fixed issue with non-required fields in a model not being marked as such #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

emann
Copy link
Collaborator

@emann emann commented Nov 11, 2020

Fixes #239

@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #240 (73d64ea) into main (1a0dc6d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #240   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           46        46           
  Lines         1302      1302           
=========================================
  Hits          1302      1302           
Impacted Files Coverage Δ
...penapi_python_client/parser/properties/__init__.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a0dc6d...73d64ea. Read the comment docs.

Copy link
Collaborator

@dbanty dbanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray, thanks! 🙏

@dbanty dbanty merged commit 43245c0 into openapi-generators:main Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional fields not marked optional for json body in 0.7.0-rc.0
2 participants