Can't generate new project with OpenAPI JSON file

[Gelbpunkt]

Describe the bug
The generator expects a YAML file, and doesn't work with JSON files, despite all examples using JSON files.

To Reproduce
Steps to reproduce the behavior:

1. openapi-python-client generate --url https://raw.githubusercontent.com/Nadybot/Nadybot/unstable/html/api.json
2. See error message about invalid YAML

Expected behavior
I expect it to load the file with JSON if YAML fails. openapi_python_client/__init__.py in _get_document only attempts to load with YAML, replacing yaml.safe_load(yaml_bytes) with json.loads(yaml_bytes) "fixes" this issue.

OpenAPI Spec File
https://raw.githubusercontent.com/Nadybot/Nadybot/unstable/html/api.json

Desktop (please complete the following information):

• OS: Fedora 34
• Python Version: 3.9.6
• openapi-python-client version 0.10.3

[dbanty]

Thanks for reporting the issue @Gelbpunkt, the problem actually isn't that the generator doesn't support JSON, YAML is a superset of JSON so YAML parsers naturally also parse JSON. In fact, if I run your JSON through a reformatter it suddenly starts parsing just fine. There's clearly still a bug here in that the parser sure doesn't like that JSON Which appears to be perfectly valid.

I'm going to poke at this a while and see if I can come up with a minimal reproducible example to narrow down where the bug is. For now curl https://raw.githubusercontent.com/Nadybot/Nadybot/unstable/html/api.json | jq > spec.json followed by openapi-python-client generate --path spec.json runs the generator... until it hits the bug in #479 which I'll hopefully resolve this weekend 😬

[Gelbpunkt]

I didn't run into #479 at all, the only issue I experienced was #487 after I replaced the yaml.safe_load with json.loads. Apart from that, the generator works as expected 😀

[dbanty]

Interestingly if I run the generator from source I also don't get #479, only when I run the installed-in-pipx version against the reformatted JSON.

[tardyp]

YAML is a superset of JSON so YAML parsers naturally also parse JSON.

Well that is not really the case. JSON supports tab as whitespace, but yaml don't.
I reproduce the same issue with a openapi json containing tabs ('\t')

yaml will not parse it:

yaml.scanner.ScannerError: while scanning for the next token
found character '\t' that cannot start any token
  in "[redacted].json", line 2, column 1

[dbanty]

Interesting, perhaps this is a bug in the YAML parser then because YAML should support tabs in the JSON-like flow syntax.

https://yaml.org/spec/1.2.2/#55-white-space-characters

[dbanty]

Thanks for the report @Gelbpunkt and the fix @tardyp! Fix is on main and will be in the 0.10.6 release (hopefully this weekend).