Skip to content

Delete JSONCPP_DEPRECATED, use [[deprecated]] instead. #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 17, 2019
Merged

Delete JSONCPP_DEPRECATED, use [[deprecated]] instead. #978

merged 10 commits into from
Jul 17, 2019

Conversation

dota17
Copy link
Member

@dota17 dota17 commented Jul 10, 2019

Language Conformance: Deletion of JSONCPP_DEPRECATED in favor of C++11's language standard [[deprecated]]

@dota17
Copy link
Member Author

dota17 commented Jul 10, 2019

The build failed in Visual Studio 2015. and the compiler showed that:
C:\projects\jsoncpp\src\lib_json\..\..\include\json/reader.h(55): error C2416: attribute 'deprecated("Use CharReader and CharReaderBuilder instead")' cannot be applied in this context.
it seems that there is a bug in Visual Studio 2015:
Wrong compilation error for deprecated nested friend function
Did Visual Studio 2015 Update 3 Break Constructor Attributes?

@baylesj
Copy link
Contributor

baylesj commented Jul 11, 2019

Added a new issue for this, #981

@baylesj
Copy link
Contributor

baylesj commented Jul 11, 2019

Good catch, I should have noticed this. If you fix the merge conflicts, this should be good to go!

@dota17
Copy link
Member Author

dota17 commented Jul 11, 2019

Good catch, I should have noticed this. If you fix the merge conflicts, this should be good to go!

Hi baylesj, the merge conflict have been fixed before, it seems that this branch has no merge conflict now.

@baylesj
Copy link
Contributor

baylesj commented Jul 11, 2019

I still see the "This branch cannot be rebased due to conflicts"

@dota17
Copy link
Member Author

dota17 commented Jul 16, 2019

I still see the "This branch cannot be rebased due to conflicts"

I uploaded an update, and the conflit check passed. Thanks to you can see more details than me, so if there are any problem, please tell me.

@baylesj baylesj merged commit b27c83f into open-source-parsers:master Jul 17, 2019
@asavah asavah mentioned this pull request Jul 18, 2019
Closed
@dota17 dota17 mentioned this pull request Aug 19, 2019
Closed
@dota17
Copy link
Member Author

dota17 commented Aug 19, 2019

Actually, [[deprecated]] is a feature in C++14, I made a typo in description:

Language Conformance: Deletion of JSONCPP_DEPRECATED in favor of C++11C++14's language standard [[deprecated]]

Tips：this #978 PR is wrote for #975 [Migrate to C++14].

Maybe there will be some compatibility problems like issue #990.

@dota17 dota17 mentioned this pull request Aug 19, 2019
Closed
res2k pushed a commit to res2k/jsoncpp that referenced this pull request Aug 21, 2019
@dota17 @res2k
Delete JSONCPP_DEPRECATED, use [[deprecated]] instead. (open-source-p…
03685a7 
…arsers#978)

* delete JSONCPP_DEPRECATED, use [[deprecated]]

* add pragma warning(disable:4996)

* add error C2416

* update

* update

* update
@dota17 dota17 deleted the deprecated_prop branch August 29, 2019 08:42
baylesj added a commit that referenced this pull request Sep 17, 2019
@baylesj
Revert "Delete JSONCPP_DEPRECATED, use [[deprecated]] instead. (#978)"
0f61e81 
This reverts commit b27c83f.
dawesc pushed a commit to EFTlab/jsoncpp that referenced this pull request Sep 25, 2019
@dota17
Delete JSONCPP_DEPRECATED, use [[deprecated]] instead. (open-source-p…
84ec631 
…arsers#978)

* delete JSONCPP_DEPRECATED, use [[deprecated]]

* add pragma warning(disable:4996)

* add error C2416

* update

* update

* update
baylesj added a commit that referenced this pull request Sep 25, 2019
@baylesj
Revert "Delete JSONCPP_DEPRECATED, use [[deprecated]] instead. (#978)" (
2a8189e 
#1029)

This reverts commit b27c83f.
baylesj added a commit that referenced this pull request Oct 11, 2019
@baylesj
Issue #958: Travis CI should enforce clang-format standards (#1026)
f34bf24 
* Issue #958: Travis CI should enfore clang-format standards

This patch adds clang format support to the travis bots.

* Update path

* Roll back to version 8 since 9 is in test

* Cleanup clang

* Revert "Delete JSONCPP_DEPRECATED, use [[deprecated]] instead. (#978)" (#1029)

This reverts commit b27c83f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dota17 @baylesj