Fixing warnings. Added JSONCPP_DEPRECATED definition for clang. Also … #641
Conversation
…updating .gitignore to ignore .DS_Store files (Mac OS Finder generated)
| return writer.write(*this); | ||
| StreamWriterBuilder builder; | ||
|
|
||
| JSONCPP_STRING out = this->hasComment(commentBefore) ? "\n" : ""; |
There was a problem hiding this comment.
This seems slow. And this might alter the behavior of toStyledString().
| @@ -1345,6 +1355,25 @@ bool OurReader::readComment() { | |||
| return true; | |||
| } | |||
|
|
|||
| JSONCPP_STRING OurReader::normalizeEOL(OurReader::Location begin, OurReader::Location end) { | |||
There was a problem hiding this comment.
I'd rather not duplicate so much code. Is there a simpler way?
|
I'm not sure this was a helpful change. Deprecation in documentation is fine, but as a compiler warning, it affects our CI builds. I don't like to see any warnings when I compile. I'm thinking of reverting this entire change, but maybe it would be enough to revert only the new deprecation warnings for the classes. |
|
Fixing the compiler warnings was actually the exact reason for making that change - when compiling with clang I'm seeing the warnings about methods and classes marked as deprecated in documentation, but not with corresponding attributes. What warnings do you see currently? |
|
Well, when I look at the AppVeyor build, I see tons of warnings now. I'd rather not see any warnings. I could live with one or two. |
…updating .gitignore to ignore .DS_Store files (Mac OS Finder generated)