Add initial Meson build file #625
Conversation
meson.build
Outdated
| '-B', | ||
| join_paths(meson.current_source_dir(), 'test/runjsontests.py'), | ||
| jsontestrunner, | ||
| join_paths(meson.current_source_dir(), 'test/data')] |
There was a problem hiding this comment.
@cdunn2001 the script likely needs some changing, it still clobbers the source tree, which isn't good
There was a problem hiding this comment.
I'm not able to discover any clobbered files. Is this upon installation?
I think I'll merge this and cut a 1.8.1 release. We can improve it later.
There was a problem hiding this comment.
$ meson --default-library shared . build
<snip>
$ ninja -C build test
ninja: Entering directory `build'
[10/11] Running all tests.
1/2 unittest_jsoncpp_test OK 0.01 s
2/2 unittest_jsontestrunner OK 1.05 s
OK: 2
FAIL: 0
SKIP: 0
TIMEOUT: 0
Full log written to /home/soap/gitz/jsoncpp/build/meson-logs/testlog.txt
$ git clean -fdx .
Removing build/
Removing test/data/test_array_01.actual
Removing test/data/test_array_01.actual-rewrite
Removing test/data/test_array_01.process-output
Removing test/data/test_array_01.rewrite
Removing test/data/test_array_02.actual
Removing test/data/test_array_02.actual-rewrite
...
All those temporary files in test/ should not be created there but in build/, as the idea of meson is not to use make clean and just rm -rf build/. You might want to consider chopping up that python script and turning it into separate parallel tests.
There was a problem hiding this comment.
All those temporary files in test/ should not be created there but in build/
I see. Seems easy to fix. But I don't see anything being clobbered, which would worry me.
There was a problem hiding this comment.
sorry for the misuse of words, my bad. I meant to say that files get added to the source tree.
There was a problem hiding this comment.
I am having a lot of trouble getting meson installed in TravisCI (in a container, so we cannot use sudo). Look at the mesonise branch in this repo.
There was a problem hiding this comment.
I'm not getting anywhere. If you want, you can try with sudo: true, which will slow down the build but will make sudo possible. Otherwise, I will probably try CodeShip when I have time.
I could merge this now, but we cannot switch to this for CI yet. We might as well get CI working on this PR.
There was a problem hiding this comment.
yes, don't merge it yet, I'm pretty close to getting it working
There was a problem hiding this comment.
@cdunn2001 I gave up on AppVeyor due to it being dumb. Travis seems to work fine now.
Great! |
|
Ah. I guess this is basically copied from here: Could you put your AppVeyor attempts on a branch? We should be able to get that working eventually. No rush though. We will probably continue to support the cmake builds too for a few months. |
No description provided.