Skip to content

std::snprintf fix for Cygwin #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2016
Merged

Conversation

Techwolfy
Copy link
Contributor

Cygwin's current GCC (v4.9.3) has the same issue as described in #406. The fix described in the previous issue (using a preprocessor flag to skip the offending #define) works for this as well.

@BillyGoto
Copy link

Could we switch to std::ostringstream instead?
Its numeric formatting is actually specified in terms of printf's output,
and it's everywhere.

On Wednesday, February 10, 2016, Daniel Ring notifications@github.com
wrote:

Cygwin's current GCC (v4.9.3) has the same issue as described in #406
#406. The fix
described in the previous issue (using a preprocessor flag to skip the

offending #define) works for this as well.

You can view, comment on, or merge this pull request online at:

#418
Commit Summary

  • std::snprintf fix for Cygwin

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#418.

ǝnɥɐuop ʎllıq

@cdunn2001
Copy link
Contributor

@BillyGoto, 👍 Definitely a good idea.

But a quick fix is fine for now.

cdunn2001 added a commit that referenced this pull request Feb 11, 2016
std::snprintf fix for Cygwin
@cdunn2001 cdunn2001 merged commit b4d2b65 into open-source-parsers:master Feb 11, 2016
Techwolfy added a commit to Techwolfy/telepresence that referenced this pull request Mar 31, 2016
…soncpp#418); removed local patch in Makefile.win.

Makefile.win no longer clears lib/jsoncpp on `make clean`, since no local modifications are made.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants