Disable -pedantic conditionally; add -pedantic-errors and -Werror conditionally #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'-pedantic' issues all warnings demanded by strict ISO C/C++; rejecting extensions that do not follow ISO C/C++. Without this option, certain GNU extensions and traditional C/C++ features are supported as well. With this option enabled building jsoncpp fails with the musl toolchain on x86 because of an incompatible posix_memalign declaration [1]. Without '-pedantic' there is no error anymore and jsoncpp builds fine. Add an option JSONCPP_WITH_STRICT_ISO to disable compilation with '-pedantic' with GCC. If jsoncpp is build with the JSONCPP_WITH_WARNING_AS_ERROR option '-pedantic-errors' is used instead. [1] https://gcc.gnu.org/ml/gcc-patches/2015-05/msg01425.html
Commit 912d550 disabled '-Werror'. Enable it if jsoncpp is build with JSONCPP_WITH_WARNING_AS_ERROR=ON.
cdunn2001
added a commit
that referenced
this pull request
Oct 30, 2015
Disable -pedantic conditionally; add -pedantic-errors and -Werror conditionally
|
Sweet. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option JSONCPP_WITH_STRICT_ISO to disable compilation with
-pedanticfor GCC. If jsoncpp is build with the JSONCPP_WITH_WARNING_AS_ERROR option-pedantic-errorsis used instead.Commit 912d550 disabled
-Werror. Enable it if jsoncpp is build with JSONCPP_WITH_WARNING_AS_ERROR=ON.