Update json_tool.h #316
Merged
Update json_tool.h #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a typo in comment.
cdunn2001
added a commit
that referenced
this pull request
Jul 17, 2015
Update json_tool.h typo in a comment
|
I think the comment's last [ was meant to indicate an open range. Either way the comment doesn't match the code! Suggest changing to [1..31] or even better describing what makes control chars deserve special treatment. Also what about 0x7F (DEL)? |
|
You're right: I'm agnostic on these kinds of changes. Submit a pull-request, and I'll merge it. |
cdunn2001
added a commit
to cdunn2001/jsoncpp
that referenced
this pull request
Jul 23, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a typo in comment.