Skip to content

CMake: Remove ancient version checks #1299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Jun 10, 2021

The minimum version for the project is CMake 3.8.0 (as set in cmake_minimum_required() at the top of the root CMakeLists.txt), so there's no point in keeping legacy code for pre-3.0 or pre-2.8 CMake.

The minimum version for the project is CMake 3.8.0, so there's
no point in keeping legacy code for pre-3.0 or pre-2.8 CMake.
@baylesj
Copy link
Contributor

baylesj commented Jun 23, 2021

Good catch, always happy to see unnecessary code deleted!!

@baylesj baylesj merged commit 65bb1b1 into open-source-parsers:master Jun 23, 2021
@ferdnyc ferdnyc deleted the cmake-old-versions branch June 26, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants