clang-tidy fixes #1033
Merged
clang-tidy fixes #1033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found with modernize-use-using Added to .clang-tidy file. Signed-off-by: Rosen Penev <rosenp@gmail.com>
Found with readability-redundant-member-init Added to .clang-tidy
Found with google-readability-casting Signed-off-by: Rosen Penev <rosenp@gmail.com>
dota17
reviewed
Sep 23, 2019
Found with modernize-use-default-member-init Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
Thanks! I'm always happy to modernize. |
dota17
pushed a commit
to dota17/jsoncpp
that referenced
this pull request
Sep 26, 2019
* [clang-tidy] Replace C typedef with C++ using Found with modernize-use-using Added to .clang-tidy file. Signed-off-by: Rosen Penev <rosenp@gmail.com> * [clang-tidy] Remove redundant member init Found with readability-redundant-member-init Added to .clang-tidy * [clang-tidy] Replace C casts with C++ ones Found with google-readability-casting Signed-off-by: Rosen Penev <rosenp@gmail.com> * [clang-tidy] Use default member init Found with modernize-use-default-member-init Signed-off-by: Rosen Penev <rosenp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.