PVS Studio static analyser reports some issues

[pavel-pimenov]

Report:
http://www.fly-server.ru/pvs-studio/jsoncpp

[cdunn2001]

Here are the 2 High priority warnings:

json_writer.cpp:624	High	V730	Not all members of a class are initialized inside the constructor. Consider inspecting: indented_.
json_value.cpp:934	High	V607	Ownerless expression '(* this)[newSize - 1]'.
--	--	--	--

I have a fix for the first, but I have no idea for the second. What is the fix for V607, and what exactly is the problem?

[pavel-pimenov]

V607 - false positive

else if (newSize > oldSize)
(*this)[newSize - 1]; <-

https://www.viva64.com/en/w/v607/

[cdunn2001]

Ah. I was looking at the wrong commit locally.

• https://github.com/open-source-parsers/jsoncpp/blob/master/src/lib_json/json_value.cpp#L934

[cdunn2001]

If you want to fix the lower priority warnings, go ahead.