nightly: Support relative submodule paths #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitPython's internal submodules support is not a direct call to the underlying git submodule interface, but does a bunch of magic that we do not need. It also does not support relative paths, which are now used in OMPI's submodule definition. Switch to using the underlying git submodule calls directly to fetch the submodules. Using the underlying submodules command required us to have a HEAD that is in refs/ as a local branch. Change the checkout command so that the branch we are building is a local branch to stop irritating git submodule commands. Signed-off-by: Brian Barrett <bbarrett@amazon.com>
jsquyres
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitPython's internal submodules support is not a direct call to
the underlying git submodule interface, but does a bunch of
magic that we do not need. It also does not support relative
paths, which are now used in OMPI's submodule definition. Switch
to using the underlying git submodule calls directly to fetch
the submodules.
Using the underlying submodules command required us to have a HEAD
that is in refs/ as a local branch. Change the checkout command
so that the branch we are building is a local branch to stop
irritating git submodule commands.
Signed-off-by: Brian Barrett bbarrett@amazon.com