Skip to content
This repository was archived by the owner on Sep 30, 2022. It is now read-only.

v1.10: cxx: "rank" is now a function in C++11 #992

Merged
merged 1 commit into from
Mar 8, 2016

Conversation

jsquyres
Copy link
Member

Use "myrank" instead (I tried using ::rank, but had varied success... so I just renamed the variable).

(cherry picked from commit open-mpi/ompi@89d0a03)

@ggouaillardet Please review.

Use "myrank" instead (I tried using ::rank, but had varied
success... so I just renamed the variable).

(cherry picked from commit open-mpi/ompi@89d0a03)
@jsquyres jsquyres added the bug label Feb 27, 2016
@jsquyres jsquyres added this to the v1.10.3 milestone Feb 27, 2016
@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1378/ for details.

@ggouaillardet
Copy link
Contributor

bot:label:pushed-back
@jsquyres the PR is good for me, but there are a lot of warnings when configure'd with --enable-picky
can you cherry-pick open-mpi/ompi@e5d6b97 into this PR ?

@jsquyres
Copy link
Member Author

jsquyres commented Mar 1, 2016

@ggouaillardet The v1.10 branch does not include the GCC diagnostic pragma; open-mpi/ompi@e5d6b97 isn't relevant here.

@ggouaillardet
Copy link
Contributor

👍

rhc54 pushed a commit that referenced this pull request Mar 8, 2016
…hark

v1.10: cxx: "rank" is now a function in C++11
@rhc54 rhc54 merged commit 0490043 into open-mpi:v1.10 Mar 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants