Skip to content

Bump Ruby from 3.0.0 to Ruby 3.3.1 and added specific platforms for images in docker compose file #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 31, 2024

Conversation

travisim
Copy link
Contributor

Tested on

Macbook Pro 16 M2 pro MacOS Sonoma 14.4.1
Docker 4.29.0 (145265)

Resolved bugs

Ruby 3.3.1 is more compatible with users of Apple silicon as Ruby 3.0.0 is unable to install.
When using Apple silicon, explicitly stating docker platform as linux/amd64 is required else the error below results. Additionally, it is required by some deployment services.

The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested

Unresolved bugs

Frontend was unable to work using the code on the original repository's latest commit, as well as this commit
Frontend errors at this pull request:

"Error: Can't add "@types/webpack-sources": invalid package version undefined."

Frontend errors at original repository's latest commit:"

The command moved into a separate package: @webpack-cli/serve
backend
Would you like to install serve? (That will run yarn add -D @webpack-cli/serve) (yes/NO)

Remarks

Replacing the whole frontend with createReactApp works but im not sure if its suitable for such a template
Overall a useful template

Copy link
Owner

@ohbarye ohbarye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

As for the frontend issue, I'll take a look when I have some time.

@ohbarye ohbarye merged commit 0d43251 into ohbarye:main May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants