Add missing notice of breaking change for accessExpireLifetime to migration guide. #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changed behavior of accessTokenLifetime is a undocumented breaking change in 3.0. The old behavior was spec-compliant and explicitly documented as an advertised fature in the CHANGELOG entry for 1.5.0, so a "Breaking Change" notice is warranted. The spec is clear that the expiration date is *recommended*, not required. Ref: https://tools.ietf.org/html/rfc6749#section-5.1
|
Thanks 👍 |
mjsalinger
pushed a commit
to mjsalinger/node-oauth2-server
that referenced
this pull request
Aug 27, 2018
…-for-expiration-times Add missing notice of breaking change for accessExpireLifetime to migration guide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message for more detail.