model.getUser needs access to req

[memelet]

Our server is multi-tenant. When using password flow to generate a JWT getUser needs to determine which tenant the user is associated with. Typically haproxy creates an X-Tenant header based on the sub-domain.

Unless I am missing something in the current implementation, there is no way for getUser to have access to any data other username, password.

Is this related to scope? Or to maybe the very early issue on state?

Any idea's how this could be incorporated? Right now I am fully blocked and will need to fork or look for another server. If I have to fork I would like some guidance on what an acceptable PR would look like.

[dmiddlecamp]

We're just running into this too for a multi-tenant feature, besides just globbing the request object on the end of the params list for the model calls (getUser, getClient, etc), is there a better way?

[memelet]

Well, I made a hack that I don't Thom will like as solution, but it got me unblocked.

I changed
return this.model.getUser.call(uname, pword, function (err, user) {..}
to
return this.model.getUser.call(this, uname, pword, function (err, user) {..}

this is the Grant instance which has properties req, res. For a hack its nice because it does not change any APIs nor breake any tests.

[dmiddlecamp]

I made a fork that passes in the request object after the callback, not sure if it's any cleaner -

https://github.com/dmiddlecamp/node-oauth2-server/blob/fixes/lib/grant.js#L238

[thomseddon]

I've seen this kind of issue a lot, I'm thinking that as a general solution we could call the model with a context that has access to the request, you could then do 'this.req.oauth' for example?

[memelet]

A context with this.req would be fine. The getUser() doesn't seem to need the models context that it gets now.

[dmiddlecamp]

That'd be great, it'd also help with overriding things like token lifetime on a request by request basis

[memelet]

Any updates on this? I'm still needing to work on a fork because of this.

[nikhil32]

I am also waiting for such feature that getUser() should have context which has request object.