Skip to content

fix: disable highlighting 'number' when CursorLine is enabled #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2022
Merged

fix: disable highlighting 'number' when CursorLine is enabled #941

merged 1 commit into from
Feb 7, 2022

Conversation

sefidel
Copy link
Contributor

@sefidel sefidel commented Feb 7, 2022

Fixes #929

@sefidel
Copy link
Contributor Author

sefidel commented Feb 7, 2022

Before the patch
before-patch

After the patch
after-patch

Copy link
Member

@kyazdani42 kyazdani42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@kyazdani42 kyazdani42 merged commit 230a61d into nvim-tree:master Feb 7, 2022
@sefidel sefidel deleted the fix-cursorline branch February 8, 2022 01:25
@wookayin
Copy link

wookayin commented Feb 9, 2022

From this patch (230a61d) neovim 0.6.0+ is required. Until this neovim 0.5.0 was working fine.

@eeeXun
Copy link
Contributor

eeeXun commented Feb 13, 2022

Could you export it to part of config? I only wanna highlight number. Or maybe I can create another PR.

@kyazdani42
Copy link
Member

in the readme: you can update window options for the tree by setting require"nvim-tree.view".View.winopts.MY_OPTION = MY_OPTION_VALUE.

@eeeXun
Copy link
Contributor

eeeXun commented Feb 13, 2022

@kyazdani42 Got it. But still, I wanna put it under require"nvim-tree".setup.view. Is it not recommended?

@kyazdani42
Copy link
Member

it is not. I might move all option configuration through an helper function to avoid people accessing the view directly.

Almo7aya pushed a commit to Almo7aya/nvim-tree.lua that referenced this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signcolumn bg showing on selected file
4 participants