feat: add normal nc highlight group

[kyazdani42]

closes #704

[mortezadadgar]

@kyazdani42 I'm getting this background color on the left side of nvim-tree window now; is there any way to sort this out

[kyazdani42]

should be fixed in 22e64cc (1.5.13)
If it still appears you can override the NvimTreeSignColumn color group to link to to Normal

[mortezadadgar]

should be fixed in 22e64cc (1.5.13) If it still appears you can override the NvimTreeSignColumn color group to link to to Normal

Thanks! linked NvimTreeSignColumn

[siduck]

@kyazdani42 how do I disable the dim? I tried using NvimTreeNormalNC's guibg as the same as NvimTreeNormal but didnt work :/

[kyazdani42]

something like hi! NvimTreeNormalNC guibg=hex_code should work normally

[mortezadadgar]

@siduck76 try this hi link NvimTreeSignColumn NvimTreeNormal

[siduck]

hi link NvimTreeSignColumn NvimTreeNormal

didnt work :c

[kyazdani42]

might be due to an ordering issue, highlights sometimes are being erased. try putting this in your colorscheme file

[gegoune]

Is it possible to completely disable this feature? It shows different SignColumn (to Normal) when active. They are the same when inactive.

[siduck]

might be due to an ordering issue, highlights sometimes are being erased. try putting this in your colorscheme file

I tried it , didnt work out :/

[smartding]

@siduck76

highlight! link NvimTreeSignColumn Normal works for me.

[siduck]

@smartding didnt work , NvimTreeNormalNC works

[kyazdani42]

a temporary solution otherwise if you cannot manage to change the colors would be to change the winhl value in the winopts.

require'nvim-tree.view'.View.winopts.winhl =  table.concat({
      'EndOfBuffer:NvimTreeEndOfBuffer',
      'Normal:NvimTreeNormal',
      'CursorLine:NvimTreeCursorLine',
      'VertSplit:NvimTreeVertSplit',
      'StatusLine:NvimTreeStatusLine',
      'StatusLineNC:NvimTreeStatuslineNC',
      'SignColumn:NvimTreeSignColumn', -- just remove this line
      'NormalNC:NvimTreeNormalNC', -- and this line
    }, ',')

EDIT: as its breaking a lot of people config i guess i'll just map those two to normal for the moment @dbarrosop you'll have to bind the normalNC yourself with hi link NvimTreeNormalNC NormalNC

[gegoune]

Still seems to be broken with 64c31aa.

1. Dimming is active (no way to completely disable it?)
2. When active, signcolumn is of different colour.

[kyazdani42]

how is that possible ? if dimming is active, it'll just show as normal which should not affect the UI. Same for signcolumn.

Could you make an issue with a small config with custom colors to demonstrate the behavior maybe ? I cannot see any of this with my colorscheme

[dbarrosop]

@kyazdani42 I actually solved by emptying the list:

    require'nvim-tree.view'.View.winopts.winhl = table.concat({})

It works and I don't require to set links or extra configuration. Assuming I don't want specific highlights for this plugin, is there any reason why I wouldn't do that? If that works and there is nothing wrong with it, maybe it could be an option you can pass to setup.

Thanks again for looking into this :)

[kyazdani42]

i'll extend the setup piece by piece, there are more interesting i want to do first (like finishing the new git integration, adding watchers to not rely on nvim events, rewriting the renderer to make it more customizable, making the initialization faster...)
We'll see, these'll come bit by bit 😄