Skip to content

chore(#2787): minimum nvim version 0.9, replace 0.10 deprecated, enable deprecated warnings #2788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Jun 9, 2024

Conversation

alex-courtis
Copy link
Member

@alex-courtis alex-courtis commented Jun 1, 2024

fixes #2787

  • tag compat-nvim-0.8

@alex-courtis alex-courtis changed the title refactor(#2787) replace deprecated in 0.10, enable deprecated warnings, updated version checks refactor(#2787): minimum nvim version 0.9, warn on nvim version 0.10 dev, enable deprecated warnings, replace 0.10 deprecated Jun 1, 2024
@alex-courtis alex-courtis changed the title refactor(#2787): minimum nvim version 0.9, warn on nvim version 0.10 dev, enable deprecated warnings, replace 0.10 deprecated refactor(#2787): minimum nvim version 0.9, replace 0.10 deprecated, enable deprecated warnings Jun 1, 2024
@alex-courtis alex-courtis changed the title refactor(#2787): minimum nvim version 0.9, replace 0.10 deprecated, enable deprecated warnings chore(#2787): minimum nvim version 0.9, replace 0.10 deprecated, enable deprecated warnings Jun 1, 2024
@ZacharyRizer
Copy link
Contributor

What needs to be done to get this merged @alex-courtis? I'd love to get that warning to go away every time nvim starts up on 0.10

@alex-courtis
Copy link
Member Author

What needs to be done to get this merged @alex-courtis? I'd love to get that warning to go away every time nvim starts up on 0.10

Test please!

How are you seeing the warning? I didn't know nvim could do that...

@ZacharyRizer
Copy link
Contributor

Maybe I misunderstood the point of this PR. I thought this was to fix the same issue that I tried to fix in this PR: #2781 which was then reverted back. My pr fixed this error from showing on start or 0.10 and 0.9 users (I thought at least).

image

But that message has come back since the above PR was reverted. Is this PR intended to fix the same issue?

@alex-courtis
Copy link
Member Author

Maybe I misunderstood the point of this PR. I thought this was to fix the same issue that I tried to fix in this PR: #2781 which was then reverted back. My pr fixed this error from showing on start or 0.10 and 0.9 users (I thought at least).

Yes, I had to revert that one as it broke 0.10 dev versions. That method was added / mutated during the dev cycle.

It's the only vim api like that, all others were updated to use the new. We could do something like testing whether is_enabled is a function and use that only when 0.10 and the function is present.

But that message has come back since the above PR was reverted. Is this PR intended to fix the same issue?

Yes! That's what I'm after - how do you run that?

:checkhealth vim.deprecated yields:


==============================================================================
vim/deprecated: 

- ERROR No healthcheck found for "vim/deprecated" plugin.

@alex-courtis
Copy link
Member Author

I've reinstated #2781 with an extra test: 46c2fb6

Please let me know how that goes.

@alex-courtis
Copy link
Member Author

@ZacharyRizer I've not forgotten about you. We will get to the bottom of this:

  • How are you running that deprecated health check?
  • Why does it only pick up that one deprecated, not the other 26?

@alex-courtis alex-courtis merged commit 8704b6f into master Jun 9, 2024
5 checks passed
@alex-courtis alex-courtis deleted the 2787-0.9-min-warn-deprecated branch June 9, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable deprecated warnings, minimum neovim version 0.9, harden support for greater versions
2 participants