Skip to content

refactor: api and command focus call tree.open(), soft deprecate tree.focus() #2558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 27, 2023
Merged

refactor: api and command focus call tree.open(), soft deprecate tree.focus() #2558

merged 2 commits into from
Nov 27, 2023

Conversation

alex-courtis
Copy link
Member

see #2554

@alex-courtis alex-courtis requested a review from gegoune November 25, 2023 23:04
gegoune
gegoune reviewed Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@gegoune gegoune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Quick tests worked just fine. Thanks!

@gegoune gegoune merged commit d5cc938 into master Nov 27, 2023
@gegoune gegoune deleted the refactor-api-focus-calls-open branch November 27, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gegoune gegoune gegoune left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alex-courtis @gegoune