ci: lua language server and Makefile #2546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I reckon we should wait until #2555 as it may make @Akmadan23 's life difficult. |
alex-courtis
commented
Nov 25, 2023
alex-courtis
commented
Nov 26, 2023
alex-courtis
commented
Dec 3, 2023
alex-courtis
force-pushed
the
ci-lua-language-server
branch
from
19ec054 to
820b7b3
Compare
alex-courtis
changed the title
gegoune
requested changes
Dec 31, 2023
.github/workflows/ci.yml
Outdated
| @@ -11,6 +11,12 @@ on: | |||
| permissions: | |||
| contents: read | |||
|
|
|||
| env: | |||
| LUA_VERSION: "5.1" | |||
There was a problem hiding this comment.
Maybe we should use matrix here instead of vars, will allow to easily extend to other versions and test them all.
There was a problem hiding this comment.
Done.
Thrashed around for a while trying to use environment variables for matrix values but failed.
The matricies do work, setting nvim_version: [ v0.8.3, v0.9.4 ] worked but failed as the annotations are not present in 0.8.3.
There was a problem hiding this comment.
I'd be most grateful if you could test the makefile as per CONTRIBUTING.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds lua-language-server check
Add Makefile
Document contributing.
Rework CI.