Skip to content

ci: ubuntu packages -> luarocks action, pin versions #2543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

alex-courtis
Copy link
Member

Brings in line with nvim-tree/nvim-web-devicons#341

  • versions pinned
  • avoids ubuntu packages

Copy link
Collaborator

@Akmadan23 Akmadan23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@Akmadan23
Copy link
Collaborator

Not sure why there are these standalone luackeck and stylua checks here...

@alex-courtis
Copy link
Member Author

Not sure why there are these standalone luackeck and stylua checks here...

Do you mean two jobs instead of one? I'm not sure either; it seems to be the pattern people follow.

The only reason I can think of is to prevent cross-contamination between jobs.

@alex-courtis alex-courtis merged commit 28cf0cd into master Nov 20, 2023
@alex-courtis alex-courtis deleted the ci-tidy-and-pin branch November 20, 2023 23:43
@Akmadan23
Copy link
Collaborator

Akmadan23 commented Nov 23, 2023

Do you mean two jobs instead of one? I'm not sure either; it seems to be the pattern people follow.

I mean that besides the three CI / * jobs, there are two named respectively luacheck and stylua with the "Expected - Waiting for status to be reported" label, which prevent me from merging the PRs (since this has been merged this "phantom" jobs appear on all PRs)

@gegoune
Copy link
Collaborator

gegoune commented Nov 23, 2023

@Akmadan23 It should be fixed now. :)

@Akmadan23
Copy link
Collaborator

It should be fixed now. :)

Thanks! What was the matter?

@gegoune
Copy link
Collaborator

gegoune commented Nov 23, 2023

Required checks are set in branch protection (settings), it still had old jobs configured as required.

@alex-courtis
Copy link
Member Author

Required checks are set in branch protection (settings), it still had old jobs configured as required.

Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants