fix: live filter delete buffer when removing overlay #2522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geril2207
force-pushed
the
fix/live-filter-remove-overlay
branch
from
802e651 to
2333811
Compare
Look accidental to me... table coercing to boolean? |
alex-courtis
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: When leaving live filter overlay we delete window, but not buffer, you can debug this and found that these buffers living all time untill you close neovim.
Solution: Add buffer deletion.
Also small improvement,
vim.api.nvim_win_closeas second argument takesforceasbooleannottable(but maybe this also working) https://neovim.io/doc/user/api.html#nvim_win_close()