fix: error when deleting opened file from floating window #2503
Conversation
geril2207
force-pushed
the
fix/floating-remove-opened-file
branch
from
a322a1d to
4e3f878
Compare
| end | ||
| vim.api.nvim_buf_delete(buf.bufnr, { force = true }) | ||
| if not view.View.float.quit_on_focus_loss then |
There was a problem hiding this comment.
found that vim.api.nvim_buf_delete does not delete the buffer if focus on float window, so firstly delete buffer then return focus.
geril2207
force-pushed
the
fix/floating-remove-opened-file
branch
from
4e3f878 to
0c54fa2
Compare
There was a problem hiding this comment.
Fantastic work, tested OK:
not float.enable
- remove only tree open
- remove open
- remove not open
- open in multiple windows
not float.enable and not float.quit_on_focus_loss
- remove only tree open
- remove open
- remove not open
- open in multiple windows
float.enable and float.quit_on_focus_loss
- remove only tree open
- remove open
- remove not open
- open in multiple windows - the window changes to
#; that's fine
float.enable and not float.quit_on_focus_loss
- remove only tree open
- remove open
- remove not open
- open in multiple windows
Please:
- add a comment RE magic number
| @@ -9,7 +9,7 @@ local M = { | |||
| } | |||
|
|
|||
| local function close_windows(windows) | |||
| if view.View.float.enable and #vim.api.nvim_list_wins() == 1 then | |||
| if view.View.float.enable and #vim.api.nvim_list_wins() < 3 then | |||
There was a problem hiding this comment.
Please leave a comment explaining the magic number 3
There was a problem hiding this comment.
Initial problem was in case where list of wins is 2 (float tree, and opened buffer), so when trying to delete opened buffer window, vim throws an error cannot close last window. Is there a case where list can be 1? If it possible we save previous condition and add if not 2(< 3 just looks more compact) which prevents from closing the last window.
There was a problem hiding this comment.
Additionally we could check if the window count is 2, and there is no floating tree, in which case we could close the window. But even with quit_on_focus_loss, list_wins length would be 2 including floating tree.
geril2207
force-pushed
the
fix/floating-remove-opened-file
branch
from
0c54fa2 to
194cc29
Compare
geril2207
force-pushed
the
fix/floating-remove-opened-file
branch
from
194cc29 to
1910367
Compare
| @@ -9,7 +9,7 @@ local M = { | |||
| } | |||
|
|
|||
| local function close_windows(windows) | |||
| if view.View.float.enable and #vim.api.nvim_list_wins() == 1 then | |||
| if view.View.float.enable and #vim.api.nvim_list_wins() < 3 then | |||
#2480