feat: use IEC binary size prefixes #2483
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm very happy that this project uses 1024 as a divisor instead of 1000. But to explicitly inform user about it the prefixes should consist of 3 letters:
Exception is any number of bytes that are less than 1024, then the prefix is just the 'B' letter.
As an addition I've completed the list with the missing prefixes: P, E, Z, Y.
Quick reference: https://en.wikipedia.org/wiki/Binary_prefix.
P.S. Ri and Qi are not yet confirmed (only SI counterparts exist starting from 2022: R, Q).