Skip to content

feat: add option to sort entries in help window #2482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 22, 2023
Merged

Conversation

Akmadan23
Copy link
Collaborator

Just an option that is nice to have

Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works beautifully. I think I'll enable this one....

Could we go one step further and add a mapping to the window to cycle sort methods?

@Akmadan23
Copy link
Collaborator Author

The only minor issue is that the keymap is hardcoded (just like q to quit), not sure if it's worth to give the user a way to customize them.

@alex-courtis
Copy link
Member

Works beautifully, no stray buffers.

The only minor issue is that the keymap is hardcoded (just like q to quit), not sure if it's worth to give the user a way to customize them.

I think that's fine; it's very clear what the mappings are and they are mnemonics.

@alex-courtis
Copy link
Member

Now that we have the clear mapping do we need the help.sort_by option?

We have too many options already...

@Akmadan23
Copy link
Collaborator Author

Now that we have the clear mapping do we need the help.sort_by option?

Well, the option can still be useful for those (like me) that don't mind changing the sorting method each time but rather have the preferred one active by default.

@alex-courtis
Copy link
Member

Well, the option can still be useful for those (like me) that don't mind changing the sorting method each time but rather have the preferred one active by default.

That's fair enough; it is something that is used frequently. We can remove or refactor if needed.

I've also got a half formed idea of executing commands that may need a help config.

Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work as always!

@alex-courtis alex-courtis merged commit 78a9ca5 into master Oct 22, 2023
@alex-courtis alex-courtis deleted the sort-help-entries branch October 22, 2023 21:57
alex-courtis added a commit that referenced this pull request Oct 30, 2023
)

* fix(#2467): remove newline in git paths

* fix: info size suffix and formatting (#2492)

- Now there is a whitespace between value and unit.
- Now values >= 1024 YiB are shown in YiB instead of B.
- To reuse same code a new local function was added: round().

* feat(#2312): fire `TextYankPost` event on path copy (#2489)

* feat(#2312): fire `TextYankPost` event on path copy

* stylua

* Bug fix

---------

Co-authored-by: Alexander Courtis <alex@courtis.org>

* feat: mapping and options to sort entries in help window (#2482)

* feat: add option to sort entries in help window

* stylua

* Add keymap to toggle sorting methods

* Bug fix

---------

Co-authored-by: Alexander Courtis <alex@courtis.org>

* fix(#2467): remove newline in git paths

* fix(#2467): change cygpath calls to array format
To avoid shell compatibility issues in msys2 environment on Windows

* stylua nit

---------

Co-authored-by: Alexander Courtis <alex@courtis.org>
Co-authored-by: Andrew Voynov <37143421+Andrew15-5@users.noreply.github.com>
Co-authored-by: Azad <49314270+Akmadan23@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants