Skip to content

fix(#2450): highlight for webp and jxl files #2451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lua/nvim-tree/renderer/init.lua
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ local picture_map = {
jpeg = true,
png = true,
gif = true,
webp = true,
jxl = true,
Copy link
Member

@alex-courtis alex-courtis Oct 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrmmm....

I was planning to remove this very-legacy mapping as it should be handled by nvim-web-devicons: #2415

nvim-tree/nvim-web-devicons#318 has been merged. Is that sufficient @zootedb0t ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icon for jxl files work now, but the highlight still doesn't apply to jxl and webp files.

Screenshot_2023-10-08-05-59-25_1920x1080

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see. I forgot about highlight...

}

function M.draw(unloaded_bufnr)
Expand Down