chore: stylua column width 120 -> 140 #2448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-courtis
commented
Oct 7, 2023
| warning, | ||
| "Please see https://github.com/nvim-tree/nvim-tree.lua/wiki/Troubleshooting#could-not-start-fs_event-for-path--emfile" | ||
| ) | ||
| M.disable_watchers "fs.inotify.max_user_watches exceeded, see https://github.com/nvim-tree/nvim-tree.lua/wiki/Troubleshooting" |
alex-courtis
commented
Oct 7, 2023
| then | ||
|
|
||
| local node_contains_buf = vim.startswith(bufpath:gsub("\\", "/"), nodepath:gsub("\\", "/") .. "/") | ||
| if M.show_on_dirs and node_contains_buf and (not node.open or M.show_on_open_dirs) then |
alex-courtis
commented
Oct 7, 2023
| .. git_status | ||
| .. '". Please open up an issue on https://github.com/nvim-tree/nvim-tree.lua/issues with this message.' | ||
| ) | ||
| notify.warn(string.format("Unrecognized git state '%s'", git_status)) |
There was a problem hiding this comment.
Message is no longer needed; we were fishing for unknown statuses.
alex-courtis
commented
Oct 7, 2023
| #M.window_picker.chars | ||
| ) | ||
| ) | ||
| notify.error(string.format("More windows (%d) than actions.open_file.window_picker.chars (%d).", #selectable, #M.window_picker.chars)) |
There was a problem hiding this comment.
Action is obvious :)
alex-courtis
commented
Oct 7, 2023
| notify.warn(string.format("system_open failed with return code %d: %s", code, process.errors)) | ||
| end | ||
|
|
||
| local opts = { args = process.args, stdio = { nil, nil, process.stderr }, detached = true } |
alex-courtis
commented
Oct 7, 2023
| opts.timeout | ||
| ) | ||
| ) | ||
| notify.warn(string.format("%d git jobs have timed out after git.timeout %dms, disabling git integration.", timeouts, opts.timeout)) |
There was a problem hiding this comment.
Message was too verbose
Akmadan23
approved these changes
Oct 7, 2023
Please do. Single line is situational, with line by line being much more readable and the general convention. Edit: I'm going to merge this one now, as we will soon get many merge conflicts. @Akmadan23 can you please raise another PR? |
Of course |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No
"if$"remaining, adds readability.#2449 increases to 160 however those long lines are genuinely too long. Manually resolved those, see with comments.