fix(#2370): Better "y/N" prompts

[mohamedarish]

fixes #2370.

Packer uses a bool flag comparing to check whether the given input is "y".

I've made it so that the default behaviour of the prompt is set to N for no (don't delete).

The default is set to R(ename) for name conflicts when copy-pasting.

Accidentally clicking enter/return after pressing d/bd should be made less common with this default behaviour.

the default behaviour is shown as a capital letter.

[mohamedarish]

I've thought about it and the "no" condition is unnecessary as everything that is not "y" is a no condition. I'm closing this PR and would be reopening this after I've fixed this issue.

[alex-courtis]

Thanks for taking the time. This one is indeed more difficult than it appears.

[mohamedarish]

I've removed all "No" conditions as they are not needed as everything that is not a "y" or "yes" entered is a no condition. And would delete/replace the files

[alex-courtis]

Many thanks for your contribution. This greatly enhances UX.

• maybe address default r
• Please update lib.prompt to convert the callback's item_short to lowercase. Users may start using uppercase to match the prompt.

[alex-courtis]

This will still populate r in the prompt.

Could we do something like:

      local prompt_input = prompt_select .. " y/n/R(ename): "
      lib.prompt(prompt_input, prompt_select, { "", "y", "n" }, { "Yes", "No", "Rename", }, function(item_short)
        utils.clear_prompt()
        if item_short == "y" then
          on_process()
        elseif item_short == "" or item_short == "r" then

I might be overlooking some consideration here...

[mohamedarish]

anything that does not start with y or n shall become r in that case?
This feels wrong and having don't copy be the default case feels better

[mohamedarish]

I'll update the lib.prompt to make the user prompt to lowercase

[alex-courtis]

anything that does not start with y or n shall become r in that case?
This feels wrong and having don't copy be the default case feels better

Yes please. Default n is consistent and arguably better behaviour. All prompts default to no.

It's a somewhat breaking change however it is quite reasonable.

[mohamedarish]

Currently "r" is auto filled when a name conflict on copy occurs and I feel that is a better behaviour than defaulting to don't copy in that case.
The user needs to remove the r or update the autofilled character as it provides a second chance to cancel by cancelling in the rename prompt

[alex-courtis]

Currently "r" is auto filled when a name conflict on copy occurs and I feel that is a better behaviour than defaulting to don't copy in that case.

I'm happy with r as the default, however auto-filling is not consistent with other prompts. We can remove the auto-fill and rename can still be the default.

[mohamedarish]

I've noticed that my change makes the prompt ui from dressing.nvim or telescope-ui-select.nvim
not have proper select prompts (Default(No) appears as is and does not fit into the prompt ui) and have updated the items_long to fix this and also fixed to change all item_short to be lowercase.

[alex-courtis]

I've noticed that my change makes the prompt ui from dressing.nvim or telescope-ui-select.nvim not have proper select prompts (Default(No) appears as is and does not fit into the prompt ui) and have updated the items_long to fix this and also fixed to change all item_short to be lowercase.

Thank you for testing.

[alex-courtis]

Please:

• resolve exception
• remove auto-fill r

[alex-courtis]

On pressing escape:

E5108: Error executing lua: ...ite/pack/packer/start/mohamedarish/lua/nvim-tree/lib.lua:151: bad argument #1 to 'lower' (string expected, got nil)
stack traceback:
        [C]: in function 'lower'
        ...ite/pack/packer/start/mohamedarish/lua/nvim-tree/lib.lua:151: in function 'on_confirm'
        /usr/share/nvim/runtime/lua/vim/ui.lua:101: in function 'input'
        ...ite/pack/packer/start/mohamedarish/lua/nvim-tree/lib.lua:150: in function 'prompt'
        ...art/mohamedarish/lua/nvim-tree/actions/fs/copy-paste.lua:114: in function 'do_single_paste'
        ...art/mohamedarish/lua/nvim-tree/actions/fs/copy-paste.lua:187: in function 'f'
        ...ite/pack/packer/start/mohamedarish/lua/nvim-tree/api.lua:32: in function <...ite/pack/packer/start/mohamedarish/lua/nvim-tree/api.lua:30>

[mohamedarish]

I have fixed the exception and added another condition in the elseif block for rename for rename to be "r"/"R" or ""

[alex-courtis]

Currently "r" is auto filled when a name conflict on copy occurs and I feel that is a better behaviour than defaulting to don't copy in that case.

I'm happy with r as the default, however auto-filling is not consistent with other prompts. We can remove the auto-fill and rename can still be the default.

[alex-courtis]

All cases tested OK.

Many thanks for your contribution.