Skip to content

feat: remove, copy, trash, bulk delete prompts default to "yes" #2337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 6, 2023
Merged

feat: remove, copy, trash, bulk delete prompts default to "yes" #2337

merged 2 commits into from
Aug 6, 2023

Conversation

yc-gao
Copy link
Contributor

@yc-gao yc-gao commented Jul 24, 2023

No description provided.

@yc-gao yc-gao changed the title chose yes default when remove feat: chose yes default when remove Jul 24, 2023
alex-courtis
alex-courtis requested changes Jul 29, 2023
View reviewed changes
Copy link
Member

@alex-courtis alex-courtis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fantastic idea! Many thanks for your contribution.

  • Please apply the same to each of these other: copy, trash, bulk delete
  • When select_prompts = true, the default is not applied

@yc-gao
Copy link
Contributor Author

yc-gao commented Aug 2, 2023 •
edited
Loading

@alex-courtis I rewrite the code. Use the first option as default in lib.prompt when select_prompts = false

@alex-courtis
Copy link
Member

@alex-courtis I rewrite the code. Use the first option as default in lib.prompt when select_prompts = false

That's really nice!

I'm happy to leave select_prompts alone; users of that likely have their own select plugin.

@alex-courtis alex-courtis changed the title feat: chose yes default when remove feat: remove, copy, trash, bulk delete prompts default to "yes" Aug 6, 2023
alex-courtis
alex-courtis approved these changes Aug 6, 2023
View reviewed changes
Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for your contribution

@alex-courtis alex-courtis merged commit 0042886 into nvim-tree:master Aug 6, 2023
@alex-courtis alex-courtis mentioned this pull request Aug 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-courtis alex-courtis alex-courtis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yc-gao @alex-courtis