feat(#2313): sort_by -> sort.sorter, add sort.folders_first default true #2314
Conversation
|
@moniquelive you are now the SME on sorting, I'd be grateful for your review and test. |
| elseif not a.nodes and b.nodes then | ||
| return false | ||
| elseif a.nodes and b.nodes then | ||
| return C.name(a, b) |
There was a problem hiding this comment.
@moniquelive should we sort folders by suffix? Does that make any sense?
There was a problem hiding this comment.
it's not very usual, but sometimes you may have folders with suffixes to disambiguate their names such as .tmp, .old, .bkp, etc. But I believe people will want to turn this directory-grouping-by-suffix on or off. Should this be another setting? This is getting fractal pretty quickly... 👀
There was a problem hiding this comment.
We have too many options... I'm happy for this to be opinionated.
Other sort methods apply the same rules to folders and files, this should too.
There was a problem hiding this comment.
Tried it, it looked odd, abandoned.
alex-courtis
changed the title
alex-courtis
changed the title
fixes #2313
rm -rf * ; mkdir -p a/10 a/20 z/10 z/20 ; touch a/5 a/15 a/25 z/15 bsort_by = "name"
sort_folders_first = true
sort_by = "name"
sort_folders_first = false
rm -rf * ; mkdir -p a.z/10 a.z/20 z.a/10 z.a/20 ; touch a.z/5 a.z/15 a.z/25 z.a/15 b.asort_by = "extension"
sort_folders_first = true
sort_by = "extension"
sort_folders_first = false
rm -rf * ; mkdir -p a.a.z/10 a.a.z/20 z.a.a/10 z.a.a/20 ; touch a.a.z/5 a.a.z/15 a.a.z/25 z.a.a/15 b.a.asort_by = "suffix"
sort_folders_first = true
sort_by = "suffix"
sort_folders_first = false
rm -rf * ; mkdir -p a.a.z/10 a.a.z/20 z.a.a/10 z.a.a/20 ; touch a.a.z/5 a.a.z/15 a.a.z/25 z.a.a/15 b.a.a ; sleep 1; touch c.a.a ; sleep 1; touch d.a.asort_by = "modification_time"
sort_folders_first = true
sort_by = "modification_time"
sort_folders_first = false
rm -rf * ; mkdir -p a/10.zig a/20.toml z/10.a z/20 ; touch a/5 a/15.c a/25.txt z/15 b.toml c.csort_by = "filetype"
sort_folders_first = true
sort_by = "filetype"
sort_folders_first = false