-
-
Notifications
You must be signed in to change notification settings - Fork 625
feat: support vim.diagnostic.is_disabled() #2232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nicely. We don't get a DiagnosticChanged
event until switching buffers or writing, but that's Good Enough: the tree is refreshed reasonably quickly.
Many thanks for your contribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve styling issue.
Done. Thanks again! |
I wonder if adding something similar to the following autocommands (from
I'll play around with this a bit today to see if this can close the gap. |
That would be great, thank you. Instant updates would look great. |
I've been looking into this, this evening and it looks like updates may already be instant. After Would it be okay to merge this PR as-is? I'm not seeing much else that can be done to improve the responsiveness at this point. |
That's fine. The UX is great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for your contribution.
My pleasure. Thanks for a great plugin! |
This PR adds support for checking
vim.diagnostic.is_disabled()
on nvim 0.9+. This function was added to support globally enabling or disabling diagnostics. This is especially useful for setups where diagnostics are enabled conditionally or on a project basis. There is no change in behavior for versions prior to 0.9.Thanks for a great plugin!