fix(#2168): Tree not reloading #2194
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improve $GIT_DIR handling - Retrieve $GIT_DIR using `git rev-parse --absolute-git-dir` - Move $GIT_DIR ignore in the project exploration part Resolves nvim-tree#1976 * Code review - move norm_path to utils.lua - fix comment nvim-tree#2012 * add comments for utils.norm_path * get_git_directory use norm_path from utils * watcher improvements --------- Co-authored-by: Alexander Courtis <alex@courtis.org>
`is_folder_ignored` uses LUA pattern to detect if a directory should be ignore or not. Unfortunately, rules on kernel filesystems was not restrictive enough, which lead to any path containing "/sys", "/proc" or "/dev" considered to be ignored.
|
Thanks @dmehala , soaking for a week. |
|
I have encountered an issue with regular file system watchers not updating the tree following a git commit. I'll enable logging and try to replicate. |
|
I just do not know what to do here: Options to reduce the blast radius:
I'm leaning towards 2, as it removes the extra git invocation for users that don't use it. *nvim-tree.git.respect_git_dir*
Attempt to resolve `$GIT_DIR`, falling back to `.git`
Type: `boolean`, Default: `false` |
alex-courtis
requested changes
May 13, 2023
4 tasks
|
I reckon this is fixed by #2263 We can reopen if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR contains:
$GIT_DIRhandling #2012The issue
is_folder_ignoredused to process the input in two steps. First, check the path against kernel filesystems withvim.startswith, then against any entry in the configuration file usingvim.fn.match.With #2012, kernel filesystems and user ignored directories share the same list and are fed to
vim.fn.match. At that point I think you understand the issue, I forgot to transform the kernel filesystem entries to regex pattern. That lead to any path containing "/dev", "/sys" and "/proc" falsely marked as ignored.