feat(api): add node.open.drop()
#2164
Conversation
|
Similar to |
doc/nvim-tree-lua.txt
Outdated
| @@ -1545,6 +1545,15 @@ node.open.vertical() *nvim-tree-api.node.open.vertical()* | |||
| node.open.horizontal() *nvim-tree-api.node.open.horizontal()* | |||
| |nvim-tree-api.node.edit()|, file will be opened in a new horizontal split. | |||
|
|
|||
| node.open.drop() *nvim-tree-api.node.open.tab()* | |||
| Switch to window with selected file if it exists. | |||
| Open file in current window otherwise. | |||
There was a problem hiding this comment.
This is strictly correct, however view._prevent_buffer_override() will always fire to eject the newly opened file.
How about "Open file otherwise"?
There was a problem hiding this comment.
Updated, good suggestion, thanks.
See #2164 (review) Idea:
I'm not sure that's really worthwhile - adds complexity, as we are second-guessing |
Co-authored-by: Alexander Courtis <alex@courtis.org>
|
Another idea here is to generalise open functionality. Accept callback/function as an argument which will be responsible for opening files, users then will be able to do whatever they want and we can provider wrappers for currently existing functionality. This would work very well for niche case such as Something like node.open(function(node) vim.cmd("drop " .. node end) |
I like that. Fits with our "API instead of specific functionality" push. The other It's more generic than that even. It's a general "do something with a node" function. Maybe |
We can remove that from documented API if we leave it in there, deprecated. |
|
That definitely makes sense! Can you see any issues with functionality such as 'close on open'? |
Anything could go wrong, depending on what the user does in the function. We know it works for the basics like :drop and quit_on_open. It's really up to the user. This opens up all sorts of options for the user e.g. window placement with no additional plumbing required. |
|
@gegoune I'm happy to merge this if you are; it works and is consistent with the other |
No description provided.