Skip to content

fix(api): find_file doesn't work when group_empty option is enabled #2100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 29, 2023
Merged

Conversation

liljaylj
Copy link
Contributor

No description provided.

@alex-courtis
Copy link
Member

Thanks for the PR @liljaylj

I'm not able to replicate this - what exactly is the problem?

Perhaps you could raise a bug report with a clean room replicator that demonstrates the problem.

Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before testing this fix a replicator is needed.

@liljaylj
Copy link
Contributor Author

liljaylj commented Apr 21, 2023

hello, created issue

@alex-courtis #2154

@liljaylj liljaylj requested a review from alex-courtis April 21, 2023 20:02
Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works nicely.

This affects core functionality; I'm going to dogfood for a week.

Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for a week. Many thanks for your contribution!

@alex-courtis alex-courtis merged commit d8b154c into nvim-tree:master Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants