feat(#1974): experimental.git.async #2094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uired for sync codepaths that loop
alex-courtis
commented
Mar 28, 2023
| @@ -59,8 +59,9 @@ function M.create_watcher(node) | |||
| else | |||
| log.line("watcher", "node event executing refresh '%s'", node.absolute_path) | |||
| end | |||
| require("nvim-tree.explorer.reload").refresh_node(node) | |||
| require("nvim-tree.renderer").draw() | |||
| require("nvim-tree.explorer.reload").refresh_node(node, function() | |||
There was a problem hiding this comment.
This is the last action, hence safe to use a callback.
alex-courtis
commented
Mar 28, 2023
| @@ -22,6 +22,21 @@ local WATCHED_FILES = { | |||
| "index", -- staging area | |||
| } | |||
|
|
|||
| local function reload_git_status(project_root, path, project, git_status) | |||
There was a problem hiding this comment.
Moved from reload_project
alex-courtis
commented
Mar 28, 2023
| @@ -103,21 +122,22 @@ local function reload_tree_at(project_root) | |||
| return | |||
| end | |||
|
|
|||
| M.reload_project(project_root) | |||
| local git_status = M.get_project(project_root) | |||
| M.reload_project(project_root, nil, function() | |||
There was a problem hiding this comment.
Safe to call back as this is the last operation of the watcher.
alex-courtis
changed the title
|
I'd like to create a sticky issue for experiments that we can link in the commit message. Draft incoming... |
alex-courtis
commented
Mar 28, 2023
| git = { | ||
| async = false, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
It looks like gitsigns has stopped (underscore prefixed) experiments.
Using the same pattern as the various lsp plugins.
|
Added issue: #2104 Dogfooded for a week; it can be reverted easily if any functionality breaks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1974
File system and .git watchers execute asynchronously.
All other operations execute synchronously. It is impractical to (ever?) make them asynchronous due to their looping nature.
Completely separate codepaths was impractical, hence some refactoring to use callbacks was done. Async/await is coming to nvim API which will allow simplification to always use callbacks for synchronous operations.
@gegoune a sanity check would be gratefully appreciated before releasing this.