Skip to content

1961 cycle detection on refresh #1996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 14, 2023
Merged

1961 cycle detection on refresh #1996

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
80a41f3
#1961 diagnostic logging refresh_nodes_for_path
alex-courtis Feb 13, 2023
3e351c2
#1961 add cycle detection to refresh_nodes_for_path
alex-courtis Feb 14, 2023
8d1d4dc
#1961 escape special characters on when path matching during refresh
alex-courtis Feb 14, 2023
216bc2b
#1961 escape special characters on when path matching during refresh
alex-courtis Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions lua/nvim-tree/explorer/reload.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,9 @@ function M.refresh_nodes_for_path(path)

local profile = log.profile_start("refresh_nodes_for_path %s", path)

-- avoids cycles
local paths_refreshed = {}

NodeIterator.builder({ explorer })
:hidden()
:recursor(function(node)
Expand All @@ -177,10 +180,13 @@ function M.refresh_nodes_for_path(path)
end
end)
:applier(function(node)
local abs_contains = node.absolute_path and path:match("^" .. node.absolute_path)
local link_contains = node.link_to and path:match("^" .. node.link_to)
local abs_contains = node.absolute_path and path:find(node.absolute_path, 1, true) ~= 1
local link_contains = node.link_to and path:find(node.link_to, 1, true) ~= 1
if abs_contains or link_contains then
M.refresh_node(node)
if not paths_refreshed[node.absolute_path] then
paths_refreshed[node.absolute_path] = true
M.refresh_node(node)
end
end
end)
:iterate()
Expand Down