Skip to content

deprecate open_on_setup #1951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 29, 2023
Merged

deprecate open_on_setup #1951

merged 2 commits into from
Jan 29, 2023

Conversation

alex-courtis
Copy link
Member

@alex-courtis alex-courtis requested a review from gegoune January 29, 2023 03:34
alex-courtis
alex-courtis commented Jan 29, 2023
View reviewed changes
lua/nvim-tree.lua
or opts.open_on_setup_file
or opts.ignore_buffer_on_setup
then
notify.info "open_on_setup behaviour has been deprecated, please see https://github.com/nvim-tree/nvim-tree.lua/wiki/Open-At-Startup"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect people might get upset, however I can't see any other way to do this.

@alex-courtis alex-courtis mentioned this pull request Jan 29, 2023
Closed
@alex-courtis
Copy link
Member Author

"Open in window from previous session" longer occurs on startup. I'll prepare a PR in case anyone misses it.

@alex-courtis alex-courtis merged commit fb775b3 into master Jan 29, 2023
polyzen added a commit to polyzen/dotfiles that referenced this pull request Feb 2, 2023
@polyzen
Nvim: nvim-tree: Open for directories and change directory
6c78947 
nvim-tree/nvim-tree.lua#1951
@polyzen
Copy link

polyzen commented Feb 2, 2023

Shouldn't netrw be allowed to work now? Now attempting to open directories is treated as opening a file, as described in #1956 (comment).

@gegoune gegoune deleted the 1669-user-startup branch February 3, 2023 01:44
@alex-courtis
Copy link
Member Author

Shouldn't netrw be allowed to work now? Now attempting to open directories is treated as opening a file, as described in #1956 (comment).

That's a really good point! netrw does have useful functionality including/excluding its "tree" handling.

With full control of the startup process, :h nvim-tree.hijack_netrw and hijack_directories.enable a user specific configuration that will work with netrw may be possible. We could come up with some Recipes and enhance the documentation around what is and is not possible.

I'd be grateful if you could explore this; some extra functionality may be required however we can address that as it arises.

kuntau added a commit to kuntau/dotfiles that referenced this pull request Feb 6, 2023
@kuntau
fix(nvim): nvim-tree deprecate open_on_setup
b9e1c19 
Reference: nvim-tree/nvim-tree.lua#1951
fnichol added a commit to fnichol/dotneovim that referenced this pull request Feb 6, 2023
@fnichol
chore(nvim-tree): remove deprecated configurations
65df512 
References: nvim-tree/nvim-tree.lua#1951

Signed-off-by: Fletcher Nichol <fnichol@nichol.ca>
polyzen added a commit to polyzen/dotfiles that referenced this pull request Feb 7, 2023
@polyzen
Nvim: nvim-tree: Open for directories and change directory
93aeb5b 
nvim-tree/nvim-tree.lua#1951
polyzen added a commit to polyzen/dotfiles that referenced this pull request Feb 7, 2023
@polyzen
Nvim: nvim-tree: Open for directories and change directory
fa5b660 
nvim-tree/nvim-tree.lua#1951
kuntau added a commit to kuntau/dotfiles that referenced this pull request Jul 12, 2024
@kuntau
fix(nvim): nvim-tree deprecate open_on_setup
6fe058a 
Reference: nvim-tree/nvim-tree.lua#1951
kuntau added a commit to kuntau/dotfiles that referenced this pull request Jul 15, 2024
@kuntau
fix(nvim): nvim-tree deprecate open_on_setup
eccdfc3 
Reference: nvim-tree/nvim-tree.lua#1951
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gegoune gegoune gegoune approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New "Open At Startup" Mechanisms
3 participants
@alex-courtis @polyzen @gegoune