Skip to content

Changing window local options does not trigger OptionSet event #1945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2023
Merged

Changing window local options does not trigger OptionSet event #1945

merged 1 commit into from
Jan 28, 2023

Conversation

tummetott
Copy link
Contributor

@tummetott tummetott commented Jan 26, 2023 •
edited
Loading

As mentioned here #1942 (comment), the eventignore solves the bug, that the OptionSet event is triggered when nvim-tree updates local window options.

This PR solves #1942 (comment)

@tummetott tummetott changed the title Changing window local options does not trigger OptionSet event. Solves #1942 Changing window local options does not trigger OptionSet event Jan 26, 2023
alex-courtis
alex-courtis approved these changes Jan 28, 2023
View reviewed changes
Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely, thank you.

"all" is a bit scary, however we are only setting options, so it's OK.

@alex-courtis alex-courtis merged commit 55028e3 into nvim-tree:master Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-courtis alex-courtis alex-courtis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tummetott @alex-courtis